[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli marked 4 inline comments as done.
fpetrogalli added inline comments.


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:116
+  bool operator==(const VFShape &Other) const {
+    return std::tie(VF, ISA, Parameters, ScalarName, VectorName) ==
+           std::tie(Other.VF, Other.ISA, Other.Parameters, Other.ScalarName,
----------------
sdesmalen wrote:
> Given that ScalarName and VectorName are not part of the equality-comparison, does that imply they should not be part of VFShape ?
I see. How about I refactor this as follow?

```
struct VFShape {
  unsigned VF;     // Vectorization factor.
  bool IsScalable; // True if the function is a scalable function.
  VFISAKind ISA;   // Instruction Set Architecture.
  SmallVector<VFParameter, 8> Parameters; // List of parameter informations.
};

struct VFInfo {
  VFShape Shape;
  StringRef ScalarName;                   // Scalar Function Name.
  StringRef VectorName; // Vector Function Name associated to this VFShape.
;
```

I think this makes more sense, I just want to double check with you before applying the changes.





CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024