[PATCH] D67444: [ARM] Add isVectorReduction MCInstrDesc flag

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 12 08:19:06 PDT 2019


SjoerdMeijer added a subscriber: MatzeB.
SjoerdMeijer added a comment.

At this point I am not sure if we should "pollute" the generic MC description with this property, mainly because the ARM backend will be the only user, and it looks like this could be simple target hook switching over the opcodes, like already done in the added unittest. Not pretty, but very simple and effective....
At the same time, there is enough prior art here, adding all sorts of things, so I am in two minds. But I think I would more lean towards a target hook, because it's not very generic/widely used.

Adding @MatzeB  as a reviewer, who had some opinions on this in past if I remember that well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67444/new/

https://reviews.llvm.org/D67444





More information about the llvm-commits mailing list