[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Looks ok.
(Note that i'm only looking at code, not correctness of demangling here.)



================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:63
+  int LinearStepOrPos = 0; // Step or Position of the Parameter.
+  unsigned Alignment = 1;  // Optional aligment, in bytes, defaulted to 1.
+
----------------
There's ongoing effort to migrate to `llvm::Alignment` (i don't recall the name)


================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:94
+/// \param PD -> ParsedData instance to store the results produced by the parse.
+bool tryParserVFABIName(const StringRef mangledName, ParsedData &PD);
+
----------------
I'm not sure why this should not also return `Optional<ParsedData>`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024