[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 16:35:06 PDT 2019


jdoerfert added a comment.

I'm fine with this (one small nit below).

@simoll, @lebedev.ri, any more comments or can this go in?



================
Comment at: llvm/lib/Analysis/VFABIDemangling.cpp:413
+                   " of the Vector Function ABI");
+}
----------------
Why is this an `Optional`? It seems to always return a proper VFParamKind if it returns at all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024





More information about the llvm-commits mailing list