[PATCH] D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass.
Alexey Lapshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 11 07:07:17 PDT 2019
avl added a comment.
In D64595#1635864 <https://reviews.llvm.org/D64595#1635864>, @rnk wrote:
> This more or less gets the behavior of `-instcombine-lower-dbg-declare=0` for structs, which is really all I cared about when I added it. The common case this flag improved is cases like the one in your test, simple C++ classes (like std::vector) stored on the stack and passed to some non-inline method call (__push_back_slow). So, I'm in favor of your change as written. In fact, I'd go further and remove the cl::opt if this lands, but let me do that since then I have to go update chromium's build to not pass it. :)
Hi @rnk, the patch is landed :-)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64595/new/
https://reviews.llvm.org/D64595
More information about the llvm-commits
mailing list