[PATCH] D67403: [AArch64] MachineCombiner FMA matching. NFC.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:3669
+    Found = Match(AArch64::FMULHrr, 1, MCP::FMULADDH_OP1);
+    Found = Match(AArch64::FMULHrr, 2, MCP::FMULADDH_OP2) ? true : Found;
     break;
----------------
sebpop wrote:
> What about avoiding the cond_expr with an or_expr? Something like this:
> ```
> Found = Match(1);
> Found |= Match(2);
> ```
Yeah, I like that, that's even better. 

Thanks for reviewing, I will make this change before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67403/new/

https://reviews.llvm.org/D67403