[PATCH] D67403: [AArch64] MachineCombiner FMA matching. NFC.

Sebastian Pop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 17:54:48 PDT 2019


sebpop added a comment.

I like the patch.  Thanks!



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:3669
+    Found = Match(AArch64::FMULHrr, 1, MCP::FMULADDH_OP1);
+    Found = Match(AArch64::FMULHrr, 2, MCP::FMULADDH_OP2) ? true : Found;
     break;
----------------
What about avoiding the cond_expr with an or_expr? Something like this:
```
Found = Match(1);
Found |= Match(2);
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67403/new/

https://reviews.llvm.org/D67403





More information about the llvm-commits mailing list