[PATCH] D67424: [Support] Add overload writeFileAtomically(std::function Writer)

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

Thanks Jan, I think this is a great improvement. IMHO the fact that we can share code outweighs the slightly increased complexity.



================
Comment at: llvm/include/llvm/Support/FileUtilities.h:107
+  /// \returns \c AtomicFileWriteError in case of error.
   llvm::Error writeFileAtomically(StringRef TempPathModel, StringRef FinalPath,
                                   StringRef Buffer);
----------------
I wonder if the temp path should be configurable or at least make it a default argument. Removing that would definitely make the call sites a little simpler. At least for LLDB I don't think the temp path matters.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67424/new/

https://reviews.llvm.org/D67424