[PATCH] D67424: [Support] Add overload writeFileAtomically(std::function Writer)

[Jan Korous via Phabricator via llvm-commits]

jkorous created this revision.
jkorous added reviewers: gribozavr, JDevlieghere, davide, tejohnson, steven_wu.
Herald added subscribers: llvm-commits, dang, kadircet, jfb, arphaman, dexonsmith, hiraditya, mehdi_amini.
Herald added a project: LLVM.

I noticed there are couple other implementations of atomic file write and replaced these with shared implementation.
I have to admit my enthusiasm for factoring this out waned a bit after I added proper error handling in lldb-platform and ThinLTOCodeGenerator as it doesn't look all that simpler than current code.
(Maybe I'm holding it wrong?) Open to suggestions.


https://reviews.llvm.org/D67424

Files:
  clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp
  clang/lib/Frontend/ASTUnit.cpp
  clang/lib/Serialization/GlobalModuleIndex.cpp
  lldb/tools/lldb-server/lldb-platform.cpp
  llvm/include/llvm/Support/FileUtilities.h
  llvm/lib/LTO/ThinLTOCodeGenerator.cpp
  llvm/lib/Support/FileUtilities.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67424.219637.patch
Type: text/x-patch
Size: 16658 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190911/517aa22d/attachment.bin>