[PATCH] D67120: [PGO] Profile guided code size optimization (continued).

[Xinliang David Li via llvm-commits]

Can you make isSuitableForJumpTable take an unused BFI parameter for
staging purpose?

David

On Tue, Sep 10, 2019 at 9:53 AM Hiroshi Yamauchi via Phabricator <
reviews at reviews.llvm.org> wrote:

> yamauchi added a comment.
>
> Split the PSI changes into https://reviews.llvm.org/D67377.
>
> It looks like the TTI part can't be separated due to dependencies and
> would pull in the whole thing:
>
> The TTI files (TargetTransformInfo.h, TargetTransformInfoImpl.h,
> BasicTTIImpl.h, TargetTransformInfo.cpp) would pull in TargetLowering.h for
> the isSuitableForJumpTable change, which then would pull in SizeOpts.h/cpp
> for the llvm::shouldOptimizeForSize change. In addition, TargetLowering.h
> would also pull in SwitchLoweringUtils.cpp for the isSuitableForJumpTable
> change, which would pull in isSuitableForJumpTable.h for findJumpTables
> change, which would pull in SelectionDAGBuilder.cpp and IRTranslator.cpp
> for the findJumpTables changes,...etc.
>
> Did you think of a different way to split the TTI part?
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D67120/new/
>
> https://reviews.llvm.org/D67120
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190910/c9ff0eab/attachment.html>