<div dir="ltr">Can you make isSuitableForJumpTable take an unused BFI parameter for staging purpose?<div><br></div><div>David</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 10, 2019 at 9:53 AM Hiroshi Yamauchi via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">yamauchi added a comment.<br>
<br>
Split the PSI changes into <a href="https://reviews.llvm.org/D67377" rel="noreferrer" target="_blank">https://reviews.llvm.org/D67377</a>.<br>
<br>
It looks like the TTI part can't be separated due to dependencies and would pull in the whole thing:<br>
<br>
The TTI files (TargetTransformInfo.h, TargetTransformInfoImpl.h, BasicTTIImpl.h, TargetTransformInfo.cpp) would pull in TargetLowering.h for the isSuitableForJumpTable change, which then would pull in SizeOpts.h/cpp for the llvm::shouldOptimizeForSize change. In addition, TargetLowering.h would also pull in SwitchLoweringUtils.cpp for the isSuitableForJumpTable change, which would pull in isSuitableForJumpTable.h for findJumpTables change, which would pull in SelectionDAGBuilder.cpp and IRTranslator.cpp for the findJumpTables changes,...etc.<br>
<br>
Did you think of a different way to split the TTI part?<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D67120/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D67120/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D67120" rel="noreferrer" target="_blank">https://reviews.llvm.org/D67120</a><br>
<br>
<br>
<br>
</blockquote></div>