[PATCH] D67053: [LLD] [COFF] Resolve source locations for undefined references using dwarf

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: COFF/SymbolTable.cpp:93
 
+static std::pair<StringRef, uint32_t> symbolizeFileLine(const SectionChunk *c,
+                                                        uint32_t addr) {
----------------
ychen wrote:
> This funtionality could be in coff::getFileLine() ?
> 
> Also, I have not idea why `coff::getFileLine` is replying on `{"", 0}` and `ExitOnError` instead of `Expected<>`.
> This funtionality could be in coff::getFileLine() ?

Well, despite the file name, it should maybe be named `getPDBFileLine()` or something like that; it's defined in PDB.cpp and specific to that format.

> Also, I have not idea why `coff::getFileLine` is replying on `{"", 0}` and `ExitOnError` instead of `Expected<>`.

That's a good point, but also feels orthogonal to this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67053/new/

https://reviews.llvm.org/D67053