[PATCH] D67053: [LLD] [COFF] Resolve source locations for undefined references using dwarf

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: COFF/SymbolTable.cpp:93
 
+static std::pair<StringRef, uint32_t> symbolizeFileLine(const SectionChunk *c,
+                                                        uint32_t addr) {
----------------
This funtionality could be in coff::getFileLine() ?

Also, I have not idea why `coff::getFileLine` is replying on `{"", 0}` and `ExitOnError` instead of `Expected<>`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67053/new/

https://reviews.llvm.org/D67053