[PATCH] D67301: [LLD] Unify the demangleItanium and demangleMSVC functions. NFC.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D67301#1662223 <https://reviews.llvm.org/D67301#1662223>, @mstorsjo wrote:

> But if we make the demangler implicitly handle both cases, it can also accidentally e.g. try to demangle any symbol which just starts with a capital Z, without any real underscore prefix, on i386 in COFF or in MachO. (I realize the current code in LLD I just committed also has this issue though.)


Just for the record, correcting myself here, no, that can't happen as the code stands right now after all. On i386, a leading underscore is consumed if present before calling the demangler.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67301/new/

https://reviews.llvm.org/D67301