[PATCH] D67301: [LLD] Unify the demangleItanium and demangleMSVC functions. NFC.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Merging the demanglers for Itanium and MSVC seems fine at the lld level because we handle only these two mangling schemes. But isn't there any mangling scheme than those two? Can all mangling schemes be distinguished reliably? If not, we can't provide a unified demangle function.

As to the underscore prefix, I prefer making it a caller's responsibility to strip it before calling a demangler. As you mentioned, callers always know which is the case.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67301/new/

https://reviews.llvm.org/D67301