[PATCH] D67232: [Attributor][Fix] Initialize the cache prior to using it

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 7 18:19:10 PDT 2019


jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:3051
+      if (LivenessAA && LivenessAA->isAssumedDead(I)) {
+        AnyDead = true;
+        continue;
----------------
sstefan1 wrote:
> xbolva00 wrote:
> > Check ´LivenessAA´ before loop
> I don't think that is practical. If LivenessAA is not null, we would still need a way to indicate it can be dereferenced. Pred should be executed even if LivenessAA is null.
I would need to duplicate the loop (as @sstefan1 noted) which is a compiler task ;) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67232/new/

https://reviews.llvm.org/D67232





More information about the llvm-commits mailing list