[PATCH] D67232: [Attributor][Fix] Initialize the cache prior to using it

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 00:06:11 PDT 2019


sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:3051
+      if (LivenessAA && LivenessAA->isAssumedDead(I)) {
+        AnyDead = true;
+        continue;
----------------
xbolva00 wrote:
> Check ´LivenessAA´ before loop
I don't think that is practical. If LivenessAA is not null, we would still need a way to indicate it can be dereferenced. Pred should be executed even if LivenessAA is null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67232/new/

https://reviews.llvm.org/D67232





More information about the llvm-commits mailing list