[PATCH] D67283: [GCOV] Skip artificial functions from being emitted

Fri Sep 6 18:06:34 PDT 2019

dblaikie added inline comments.

================
Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:731-732

           // Artificial lines such as calls to the global constructors.
           if (Loc.getLine() == 0 || Loc.isImplicitCode())
             continue;
----------------
rnk wrote:
> Artificial lines here are skipped. If gcov is running, it means that we have an artificial function which contains non-artificial debug locations, otherwise functionHasLines would return false. Do you think we should just add this guard to the other addLine call maybe?
> 
> + at nlewycky @dblaikie, since they show up in the blame at rL210239, which added this check.
It's... errr... been a while?

I'm not sure I'll be much more use than a blind/fresh reading of the code/commit history here. But if it's useful to have a second set of eyes (mine) - I might need more words (just rephrasing your question, @rnk with some more words to help me understand what's happening here/being proposed)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67283/new/

https://reviews.llvm.org/D67283