[PATCH] D67283: [GCOV] Skip artificial functions from being emitted
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 6 15:45:31 PDT 2019
rnk added subscribers: nlewycky, dblaikie.
rnk added inline comments.
================
Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:731-732
// Artificial lines such as calls to the global constructors.
if (Loc.getLine() == 0 || Loc.isImplicitCode())
continue;
----------------
Artificial lines here are skipped. If gcov is running, it means that we have an artificial function which contains non-artificial debug locations, otherwise functionHasLines would return false. Do you think we should just add this guard to the other addLine call maybe?
+ at nlewycky @dblaikie, since they show up in the blame at rL210239, which added this check.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67283/new/
https://reviews.llvm.org/D67283
More information about the llvm-commits
mailing list