[PATCH] D63672: Added Delta IR Reduction Tool

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 13:32:42 PDT 2019


dblaikie added a comment.

In D63672#1660282 <https://reviews.llvm.org/D63672#1660282>, @mgorny wrote:

> In D63672#1659973 <https://reviews.llvm.org/D63672#1659973>, @dblaikie wrote:
>
> > In D63672#1657198 <https://reviews.llvm.org/D63672#1657198>, @mgorny wrote:
> >
> > > In D63672#1657183 <https://reviews.llvm.org/D63672#1657183>, @mgorny wrote:
> > >
> > > > Ok, I have an idea of using `--test-arg` but it would require the args to be passed before the filename. I'll post a patch.
> > >
> > >
> > > Actually, I won't because I'm hitting some memory corruption in `TestArgs` and I don't really have time or motivation to fight it. Please fix your code.
> >
> >
> > Could you be more specific? I've tried running both tests under valgrind and haven't encountered any reported errors there.
>
>
> In my case, passing `--test-arg` to the program caused `TestArgs` inside `TestRunner` to contain junk before the actual parameter strings.


Ah - so was this not while running one of the existing tests, but running some other commands? Could you provide reproduction steps, then? (exactly what inputs, commands, etc)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63672/new/

https://reviews.llvm.org/D63672





More information about the llvm-commits mailing list