[PATCH] D63672: Added Delta IR Reduction Tool

Thu Sep 5 22:38:39 PDT 2019

mgorny added a comment.

In D63672#1659973 <https://reviews.llvm.org/D63672#1659973>, @dblaikie wrote:

> In D63672#1657198 <https://reviews.llvm.org/D63672#1657198>, @mgorny wrote:
>
> > In D63672#1657183 <https://reviews.llvm.org/D63672#1657183>, @mgorny wrote:
> >
> > > Ok, I have an idea of using `--test-arg` but it would require the args to be passed before the filename. I'll post a patch.
> >
> >
> > Actually, I won't because I'm hitting some memory corruption in `TestArgs` and I don't really have time or motivation to fight it. Please fix your code.
>
>
> Could you be more specific? I've tried running both tests under valgrind and haven't encountered any reported errors there.

In my case, passing `--test-arg` to the program caused `TestArgs` inside `TestRunner` to contain junk before the actual parameter strings.

================
Comment at: llvm/trunk/test/Reduce/Inputs/remove-funcs.py:1
+#!/usr/bin/env python
+
----------------
dblaikie wrote:
> mgorny wrote:
> > This is broken on systems with non-standard Python executable name. You ought to use lit's `%python` substitution to invoke Python. However, I don't really know how to combine that with llvm-reduce.
> I've provided what I believe to be a fix for this in r371143
Heh, that's a hack I wouldn't think of. Thanks.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63672/new/

https://reviews.llvm.org/D63672