[PATCH] D56455: [ADT] Fix SmallDenseMap assertion with large InlineBuckets

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 12:58:58 PDT 2019


nikic added a comment.

@atrick That invariant doesn't exist currently. If a SmallDenseMap with less than InlineBuckets elements is compacted, it will change to the large rep (with an allocation). After this change it will instead stay in the small rep (without an allocation).

The short-circuit condition `AtLeast < InlineBuckets` is dead code right now, I think, because NumBuckets is >= InlineBuckets and AtLeast is either NumBuckets or NumBuckets*2.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56455/new/

https://reviews.llvm.org/D56455





More information about the llvm-commits mailing list