[PATCH] D56455: [ADT] Fix SmallDenseMap assertion with large InlineBuckets
Andrew Trick via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 6 10:19:00 PDT 2019
atrick added a comment.
Can this problem be fixed without losing the invariant that memory is never allocated until `NumBuckets > InlineBuckets`, regardless of the load? I don't like the removal of the fast path `if (AtLeast < InlineBuckets)` and the load doesn't matter at all in small mode!
e.g. If I ask to reserve 100 out of 128 entries, it should not attempt to copy all the entries into temporary storage.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56455/new/
https://reviews.llvm.org/D56455
More information about the llvm-commits
mailing list