[PATCH] D66625: [X86] Print register names in .seh_* directives

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3612
+    return parseDirectiveSEHPushFrame(DirectiveID.getLoc());
 
   return true;
----------------
aganea wrote:
> `if (IDVal == ".seh_stackalloc")` is not being handled here, but you've added `X86AsmParser::parseDirectiveSEHAllocStack`. Is that intended?
No, that's a mistake, thanks. I was surprised to discover that the AArch64 SEH asm parsing code supports this directive and does something with it, so I had to move it back to MCStreamer, and forgot to delete this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66625/new/

https://reviews.llvm.org/D66625