[PATCH] D66625: [X86] Print register names in .seh_* directives

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 08:20:24 PDT 2019


aganea added inline comments.
Herald added a subscriber: ychen.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3612
+    return parseDirectiveSEHPushFrame(DirectiveID.getLoc());
 
   return true;
----------------
`if (IDVal == ".seh_stackalloc")` is not being handled here, but you've added `X86AsmParser::parseDirectiveSEHAllocStack`. Is that intended?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66625/new/

https://reviews.llvm.org/D66625





More information about the llvm-commits mailing list