[PATCH] D67256: [yaml2obj] Simplify p_filesz/p_memsz computing

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 03:03:49 PDT 2019


MaskRay updated this revision to Diff 219054.
MaskRay added a comment.

Support multiple trailing SHT_NOBITS.

lld/ELF/Writer.cpp does not use the trick (two or more SHT_NOBITS are tricky and IIRC, when more than 1 SHF_TLS SHT_NOBITS sections are used, ld.bfd can get addresses wrong). However, since I can do it with 1 fewer line here :) Let me do it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67256/new/

https://reviews.llvm.org/D67256

Files:
  lib/ObjectYAML/ELFEmitter.cpp
  test/tools/yaml2obj/program-header-size-offset.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67256.219054.patch
Type: text/x-patch
Size: 4014 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190906/3b8653a0/attachment.bin>


More information about the llvm-commits mailing list