[PATCH] D67256: [yaml2obj] Simplify p_filesz/p_memsz computing
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 6 02:31:45 PDT 2019
grimar added a comment.
This looks good. Would be nice if someone else also take a look.
================
Comment at: lib/ObjectYAML/ELFEmitter.cpp:630
+ // sections.
+ uint64_t FileEnd = PHeader.p_offset, MemEnd = PHeader.p_offset;
+ for (Elf_Shdr *SHeader : Sections) {
----------------
When I first saw `FileEnd` I thought it is somehow related to the end of file.
Maybe `FileOffset` vs `MemOffset` is better? (Or some different better names)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67256/new/
https://reviews.llvm.org/D67256
More information about the llvm-commits
mailing list