[PATCH] D66976: Small update to Expected<StringRef>

Fri Sep 6 01:31:06 PDT 2019

grimar added a comment.

In D66976#1659909 <https://reviews.llvm.org/D66976#1659909>, @dblaikie wrote:

> In D66976#1658737 <https://reviews.llvm.org/D66976#1658737>, @MaskRay wrote:
>
> > In D66976#1658669 <https://reviews.llvm.org/D66976#1658669>, @dblaikie wrote:
> >
> > > Any chance of a test case? This looks like it fixed a bug/difference in behavior.
> >
> >
> > rL370669 <https://reviews.llvm.org/rL370669> added a test
>
>
> That doesn't seem to test this patch, though - if I revert this patch no tests fail.

Did you set `LLVM_ENABLE_ABI_BREAKING_CHECKS` to `1`?

Before this patch `NameOrErr` was not consumed/ignored by `consumeError`.
If you revert it and run the test from rL370669 <https://reviews.llvm.org/rL370669>, you should get a
"Expected<T> must be checked before access or destruction" failture.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66976/new/

https://reviews.llvm.org/D66976