[PATCH] D66976: Small update to Expected<StringRef>

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 15:17:58 PDT 2019


dblaikie added a comment.

In D66976#1658737 <https://reviews.llvm.org/D66976#1658737>, @MaskRay wrote:

> In D66976#1658669 <https://reviews.llvm.org/D66976#1658669>, @dblaikie wrote:
>
> > Any chance of a test case? This looks like it fixed a bug/difference in behavior.
>
>
> rL370669 <https://reviews.llvm.org/rL370669> added a test


That doesn't seem to test this patch, though - if I revert this patch no tests fail.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66976/new/

https://reviews.llvm.org/D66976





More information about the llvm-commits mailing list