[PATCH] D64953: GlobalISel: Support physical register inputs in patterns

Thu Sep 5 19:57:24 PDT 2019

arsenm marked an inline comment as done.
arsenm added inline comments.

================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:3881-3882

+    // FIXME: Is this necessary? Seems to avoid problems with interactions with
+    // special WZR handling.
     if (ChildRec->isSubClassOf("Register")) {
----------------
dsanders wrote:
> dsanders wrote:
> > I don't think I understand this comment, it doesn't really give enough context to know why the necessity is in doubt or the problems it avoids
> This is the only bit that's holding me back from giving a conditional LGTM as I don't understand the comment and therefore I'm not sure if it's an issue. Could you elaborate on what the problems are and why the necessity is in doubt?
I think this is a leftover from an early iteration. I don't remember why I was trying to remove this, or see why its should be

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64953/new/

https://reviews.llvm.org/D64953