[PATCH] D29641: [SLP] Fix for PR31847: Assertion failed: (isLoopInvariant(Operands[i], L) && "SCEVAddRecExpr operand is not loop-invariant!")

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: include/llvm/Transforms/Vectorize/SLPVectorizer.h:27
 #include "llvm/IR/PassManager.h"
 #include "llvm/IR/ValueHandle.h"
 
----------------
Do we need this include any more? Or can it be moved to SLPVectorizer.cpp?


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:5875
       }
+      llvm_unreachable("Reduction kind is not set");
     }
----------------
Why is this change necessary?


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:5895
       }
+      llvm_unreachable("Reduction kind is not set");
     }
----------------
Why is this change necessary?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29641/new/

https://reviews.llvm.org/D29641