[PATCH] D67125: [PowerPC][AIX] Adds support for writing the data section in object files

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:309
+
+  // Write the data CSections one at a time.
+  for (const auto CSection : DataCsects)
----------------
minor nit: `CSections` --> `control sections` or `csects`.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:478
+    // Write out the control section first and then each symbol in it.
+    writeSymbolTableEntryForControlSection(CSection, Data, XCOFF::C_HIDEXT);
+    for (const auto Sym : CSection.Syms) {
----------------
Storage class should come from CSection.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67125/new/

https://reviews.llvm.org/D67125