[PATCH] D67125: [PowerPC][AIX] Adds support for writing the data section in object files

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 11:58:35 PDT 2019


jasonliu added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:539
+           "Improperly aligned address for section.");
+    uint32_t StartAddress = Address;
+    for (auto &Csect : DataCsects) {
----------------
We assigned Index and Size to Data section. But we haven't assign Address to it. By default, the address would be 0. It's correct if you do not have a Text section. But once you have text section, the Data's address as 0 would wrong. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67125/new/

https://reviews.llvm.org/D67125





More information about the llvm-commits mailing list