[llvm] r369529 - [DWARF] Adjust return type of DWARFUnit::getLength().

[David Blaikie via llvm-commits]

Ideally test cases would be good to cover this functionality and
demonstrate the length is no longer truncated.

On Wed, Aug 21, 2019 at 7:09 AM Igor Kudrin via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: ikudrin
> Date: Wed Aug 21 07:10:57 2019
> New Revision: 369529
>
> URL: http://llvm.org/viewvc/llvm-project?rev=369529&view=rev
> Log:
> [DWARF] Adjust return type of DWARFUnit::getLength().
>
> DWARFUnitHeader::getLength() returns uint64_t.
> DWARFUnit::getLength() should do the same.
>
> Differential Revision: https://reviews.llvm.org/D66472
>
> Modified:
>     llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h
>     llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp
>     llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp
>
> Modified: llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h?rev=369529&r1=369528&r2=369529&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h (original)
> +++ llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h Wed Aug 21
> 07:10:57 2019
> @@ -286,7 +286,7 @@ public:
>    uint8_t getDwarfOffsetByteSize() const {
>      return Header.getDwarfOffsetByteSize();
>    }
> -  uint32_t getLength() const { return Header.getLength(); }
> +  uint64_t getLength() const { return Header.getLength(); }
>    uint8_t getUnitType() const { return Header.getUnitType(); }
>    bool isTypeUnit() const { return Header.isTypeUnit(); }
>    uint64_t getNextUnitOffset() const { return Header.getNextUnitOffset();
> }
>
> Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp?rev=369529&r1=369528&r2=369529&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp (original)
> +++ llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp Wed Aug 21
> 07:10:57 2019
> @@ -16,7 +16,7 @@ using namespace llvm;
>
>  void DWARFCompileUnit::dump(raw_ostream &OS, DIDumpOptions DumpOpts) {
>    OS << format("0x%08" PRIx64, getOffset()) << ": Compile Unit:"
> -     << " length = " << format("0x%08x", getLength())
> +     << " length = " << format("0x%08" PRIx64, getLength())
>       << " version = " << format("0x%04x", getVersion());
>    if (getVersion() >= 5)
>      OS << " unit_type = " << dwarf::UnitTypeString(getUnitType());
>
> Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp?rev=369529&r1=369528&r2=369529&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp (original)
> +++ llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp Wed Aug 21 07:10:57
> 2019
> @@ -24,12 +24,12 @@ void DWARFTypeUnit::dump(raw_ostream &OS
>    if (DumpOpts.SummarizeTypes) {
>      OS << "name = '" << Name << "'"
>         << " type_signature = " << format("0x%016" PRIx64, getTypeHash())
> -       << " length = " << format("0x%08x", getLength()) << '\n';
> +       << " length = " << format("0x%08" PRIx64, getLength()) << '\n';
>      return;
>    }
>
>    OS << format("0x%08" PRIx64, getOffset()) << ": Type Unit:"
> -     << " length = " << format("0x%08x", getLength())
> +     << " length = " << format("0x%08" PRIx64, getLength())
>       << " version = " << format("0x%04x", getVersion());
>    if (getVersion() >= 5)
>      OS << " unit_type = " << dwarf::UnitTypeString(getUnitType());
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190904/921835b2/attachment.html>