<div dir="ltr">Ideally test cases would be good to cover this functionality and demonstrate the length is no longer truncated.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Aug 21, 2019 at 7:09 AM Igor Kudrin via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: ikudrin<br>
Date: Wed Aug 21 07:10:57 2019<br>
New Revision: 369529<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=369529&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=369529&view=rev</a><br>
Log:<br>
[DWARF] Adjust return type of DWARFUnit::getLength().<br>
<br>
DWARFUnitHeader::getLength() returns uint64_t.<br>
DWARFUnit::getLength() should do the same.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D66472" rel="noreferrer" target="_blank">https://reviews.llvm.org/D66472</a><br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h<br>
    llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp<br>
    llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h?rev=369529&r1=369528&r2=369529&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h?rev=369529&r1=369528&r2=369529&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h (original)<br>
+++ llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFUnit.h Wed Aug 21 07:10:57 2019<br>
@@ -286,7 +286,7 @@ public:<br>
   uint8_t getDwarfOffsetByteSize() const {<br>
     return Header.getDwarfOffsetByteSize();<br>
   }<br>
-  uint32_t getLength() const { return Header.getLength(); }<br>
+  uint64_t getLength() const { return Header.getLength(); }<br>
   uint8_t getUnitType() const { return Header.getUnitType(); }<br>
   bool isTypeUnit() const { return Header.isTypeUnit(); }<br>
   uint64_t getNextUnitOffset() const { return Header.getNextUnitOffset(); }<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp?rev=369529&r1=369528&r2=369529&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp?rev=369529&r1=369528&r2=369529&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp (original)<br>
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp Wed Aug 21 07:10:57 2019<br>
@@ -16,7 +16,7 @@ using namespace llvm;<br>
<br>
 void DWARFCompileUnit::dump(raw_ostream &OS, DIDumpOptions DumpOpts) {<br>
   OS << format("0x%08" PRIx64, getOffset()) << ": Compile Unit:"<br>
-     << " length = " << format("0x%08x", getLength())<br>
+     << " length = " << format("0x%08" PRIx64, getLength())<br>
      << " version = " << format("0x%04x", getVersion());<br>
   if (getVersion() >= 5)<br>
     OS << " unit_type = " << dwarf::UnitTypeString(getUnitType());<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp?rev=369529&r1=369528&r2=369529&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp?rev=369529&r1=369528&r2=369529&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp (original)<br>
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp Wed Aug 21 07:10:57 2019<br>
@@ -24,12 +24,12 @@ void DWARFTypeUnit::dump(raw_ostream &OS<br>
   if (DumpOpts.SummarizeTypes) {<br>
     OS << "name = '" << Name << "'"<br>
        << " type_signature = " << format("0x%016" PRIx64, getTypeHash())<br>
-       << " length = " << format("0x%08x", getLength()) << '\n';<br>
+       << " length = " << format("0x%08" PRIx64, getLength()) << '\n';<br>
     return;<br>
   }<br>
<br>
   OS << format("0x%08" PRIx64, getOffset()) << ": Type Unit:"<br>
-     << " length = " << format("0x%08x", getLength())<br>
+     << " length = " << format("0x%08" PRIx64, getLength())<br>
      << " version = " << format("0x%04x", getVersion());<br>
   if (getVersion() >= 5)<br>
     OS << " unit_type = " << dwarf::UnitTypeString(getUnitType());<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>