[PATCH] D67109: [ARM] Add patterns for CTLZ on MVE

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 08:49:55 PDT 2019


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of formatting nits below.



================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:1728
+let Predicates = [HasMVEInt] in {
+  def : Pat<(v16i8 ( ctlz (v16i8 MQPR:$val1))),
+            (v16i8 ( MVE_VCLZs8 (v16i8 MQPR:$val1)))>;
----------------
You can remove the spaces before the ctlz, and before the MVE_VCLZs8 below.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:1734
+            (v8i16 ( MVE_VCLZs16 (v8i16 MQPR:$val1)))>;
+
+}
----------------
And this empty line.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67109/new/

https://reviews.llvm.org/D67109





More information about the llvm-commits mailing list