[PATCH] D67150: [lib/ObjectYAML] - Stop calling error(1) when mapping the st_other field of a symbol.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/tools/yaml2obj/elf-symbol-stother.yaml:7
 # RUN: not yaml2obj --docnum=1 2>&1 %s | FileCheck %s --check-prefix=ERR
-# ERR: error: an unknown value is used for symbol's 'Other' field: STO_MIPS_OPTIONAL.
+# ERR: error: an unknown value is used for symbol's 'Other' field: STO_MIPS_OPTIONAL
 
----------------
grimar wrote:
> I am not sure if we want a full stop at the end or not. Looking at the code it seems we are not consistent atm.
Since we are already inconsistent, we can probably follow other tools - uncapitalize and remove full stops.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67150/new/

https://reviews.llvm.org/D67150