[PATCH] D67150: [lib/ObjectYAML] - Stop calling error(1) when mapping the st_other field of a symbol.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 03:34:31 PDT 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: test/tools/yaml2obj/elf-symbol-stother.yaml:7
 # RUN: not yaml2obj --docnum=1 2>&1 %s | FileCheck %s --check-prefix=ERR
-# ERR: error: an unknown value is used for symbol's 'Other' field: STO_MIPS_OPTIONAL.
+# ERR: error: an unknown value is used for symbol's 'Other' field: STO_MIPS_OPTIONAL
 
----------------
I am not sure if we want a full stop at the end or not. Looking at the code it seems we are not consistent atm.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67150/new/

https://reviews.llvm.org/D67150





More information about the llvm-commits mailing list