[PATCH] D66935: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 15:32:20 PDT 2019


sdesmalen marked an inline comment as done.
sdesmalen added a comment.

In D66935#1656470 <https://reviews.llvm.org/D66935#1656470>, @efriedma wrote:

> This seems much better.


Thanks!

> Did you intentionally skip updating ShrinkWrap?  Should be straightforward. (There's a bunch of places in that file that reference a RegScavenger, but nothing actually uses it.)

Yes, ShrinkWrap still needs to use the `determineCalleeSaves` interface because it is run before PEI when `CalleeSavedInfo` in MachineFrameInfo has not yet been populated (and thus `MFI.isCalleeSavedInfoValid()` will return false).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66935/new/

https://reviews.llvm.org/D66935





More information about the llvm-commits mailing list