[PATCH] D66935: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

This seems much better.

Did you intentionally skip updating ShrinkWrap?  Should be straightforward. (There's a bunch of places in that file that reference a RegScavenger, but nothing actually uses it.)



================
Comment at: llvm/include/llvm/CodeGen/TargetFrameLowering.h:294
   /// This method also sets up the register scavenger ensuring there is a free
   /// register or a frameindex available.
   virtual void determineCalleeSaves(MachineFunction &MF, BitVector &SavedRegs,
----------------
Maybe add a comment here that this shouldn't be called by anything outside of PEI.


================
Comment at: llvm/lib/CodeGen/RegisterScavenging.cpp:802
     BitVector SavedRegs;
-    TFL.determineCalleeSaves(MF, SavedRegs, &RS);
+    TFL.getCalleeSaves(MF, SavedRegs);
     TFL.processFunctionBeforeFrameFinalized(MF, &RS);
----------------
ScavengerTest might actually want the real determineCalleeSaves?  In this context, it's basically acting as a substitute for PEI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66935/new/

https://reviews.llvm.org/D66935