[PATCH] D67097: [DWARF] Check for format mismatch between CU and Range List Table.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 12:53:44 PDT 2019


dblaikie added a comment.

I'm not sure if using "OffsetIn" in the diagnostic is the right thing to do.

Honestly the fact that DWARFv5 specifies that the "rnglist base address" (& loclist bast address, and str_offsets base) point to the beginning of the list rather than the start of the header is super quirky and I don't think it's helpful to users to highlight that. (though I doubt DWARFvNext would bother fixing this - it'sjust quirky, not super problematic for any practical reasons I can think of)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67097/new/

https://reviews.llvm.org/D67097





More information about the llvm-commits mailing list