[PATCH] D67097: [DWARF] Check for format mismatch between CU and Range List Table.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 09:28:46 PDT 2019


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/DebugInfo/DWARF/DWARFUnit.cpp:311
+                        DwarfFormat Format) {
+  const uint64_t OffsetIn = Offset;
   // TODO: Support DWARF64
----------------
ikudrin wrote:
> Orlando wrote:
> > Is there a reason for OffsetIn to exist as opposed to just using Offset here?
> `Offset` is changed in `Table.extractHeaderAndOffsets()` (line 323), but we have to show the original value in the error message (line 326).
Perhaps: `StartOffset`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67097/new/

https://reviews.llvm.org/D67097





More information about the llvm-commits mailing list