[PATCH] D67121: [TargetLowering] Make allowsMemoryAccess methode virtual.

[James Molloy via Phabricator via llvm-commits]

jmolloy added a comment.

> Your problem sounds more like we need a better system for checking if a store/trunc store is legal

I do sort of agree but this is potentially a deep hole to dive into. In particular the issue here isn't actually trunc-stores, as a trunc-store is equivalent to trunc + AssertZext + store. It's that we're creating a store with a memory bitwidth that isn't supported, and undoing that is really hard.

I'm not sure I completely understand your objection though - You've mentioned how allowsMemoryAccess is intended to be used, but why is it intended in that way? I think I may lack some backcontext.

The comment, signature and name appear to me to be the exact test needed in this case?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67121/new/

https://reviews.llvm.org/D67121