[PATCH] D67121: [TargetLowering] Make allowsMemoryAccess methode virtual.
Thomas Raoux via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 3 11:49:34 PDT 2019
ThomasRaoux added a comment.
In D67121#1656161 <https://reviews.llvm.org/D67121#1656161>, @arsenm wrote:
> It seems to me like this is a workaround for the quite inadequate system for defining legality for a load/store. I think allowsMemoryAccess is poorly named; It exists to just check if the type is aligned before calling allowsMisalignedMemoryAccesses. Your problem sounds more like we need a better system for checking if a store/trunc store is legal
The comment mentions "Return true if the target supports a memory access of this type for the given address space and alignment". So I assumed it is responsible for more than checking alignment. Is this not correct?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67121/new/
https://reviews.llvm.org/D67121
More information about the llvm-commits
mailing list