[PATCH] D67110: AMDGPU: Make VReg_1 size be 1

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 11:02:30 PDT 2019


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.td:677
 def VReg_1 : RegisterClass<"AMDGPU", [i1], 32, (add VGPR_32)> {
-  let Size = 32;
+  let Size = 1;
 }
----------------
arsenm wrote:
> rampitec wrote:
> > This is spill size. How does that work when spill size if 1?
> VReg_1 should never be seen by a spill. This could also be rounded when spilling
Why are you sure it will never be spilled?
Also if it is never spilled why is this field even matter?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67110/new/

https://reviews.llvm.org/D67110





More information about the llvm-commits mailing list