[PATCH] D66600: Add encode and decode methods to InlineInfo and document encoding format to the GSYM file format

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 09:27:27 PDT 2019


MaskRay added inline comments.


================
Comment at: lib/DebugInfo/GSYM/Range.cpp:53
+    return false;
+  return Range.Start < It[-1].End && Range.End <= It[-1].End;
+}
----------------
Did you intend to use `It[-1].End` twice?

I am not certain what this function intends to do, but 
should it be `return Range.End <= It[-1].End;`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66600/new/

https://reviews.llvm.org/D66600





More information about the llvm-commits mailing list