[PATCH] D66600: Add encode and decode methods to InlineInfo and document encoding format to the GSYM file format

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks for implementing the error handling! There is one more comment inline.



================
Comment at: lib/DebugInfo/GSYM/InlineInfo.cpp:127
+  // it will waste space in the GSYM file.
+  if (!isValid())
+    return createStringError(std::errc::invalid_argument,
----------------
What's the advantage of having invalid InlineInfo objects? Could we just have whoever creates them return a a valid object or an error otherwise?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66600/new/

https://reviews.llvm.org/D66600