[PATCH] D67039: [ELF] Add a spell corrector for "undefined symbol" diagnostics

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 218328.
MaskRay marked 10 inline comments as done.
MaskRay edited the summary of this revision.
MaskRay added a comment.

> Interesting idea. I suspect we'll need to modify it over time in response to feedback. For example, what if there are several candidates, should we report them all, give one stronger weighting etc.

Agree. We can wait for user feedback.

> One thing I don't think it will catch, which is my most common and least favourite typo, is a transposition which is usually a distance of 2.

Added transposition.

> I'm less concerned about the algorithm speed at the moment as it should only trigger in an error case, and if it aids debugging then it is time well spent.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67039/new/

https://reviews.llvm.org/D67039

Files:
  ELF/Relocations.cpp
  test/ELF/undef-spell-corrector.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67039.218328.patch
Type: text/x-patch
Size: 6308 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190902/d7cd787c/attachment.bin>