[PATCH] D67039: [ELF] Add a spell corrector for "undefined symbol" diagnostics
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 2 02:53:00 PDT 2019
peter.smith added inline comments.
================
Comment at: ELF/Relocations.cpp:694
+static const Symbol *correctSpelling(const Symbol &sym) {
+ // Build a map of local defined symbols.
----------------
ruiu wrote:
> Please add a file comment saying that this function is for "did you mean?" feature.
I suggest getAlternativeSpelling as there could be many symbols within the same distance, particularly sym1, sym2, sym9 for correctSpelling(sym)
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67039/new/
https://reviews.llvm.org/D67039
More information about the llvm-commits
mailing list