[PATCH] D64953: GlobalISel: Support physical register inputs in patterns

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 31 16:39:34 PDT 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: test/TableGen/gisel-physreg-input.td:52-54
+// Try using the name of the physreg in another operand FIXME: Does
+// this make any sense, or should it be an error? It ends up requiring
+// the two be the same operand.
----------------
dsanders wrote:
> I think this is fine so long as the user is choosing the names. I'm not keen on it when a generated name and a chosen name are the same.
The new version avoids names for physical registers, this comment is out of date


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64953/new/

https://reviews.llvm.org/D64953





More information about the llvm-commits mailing list